[Webkit-unassigned] [Bug 28862] [Qt][API] Add a new QGraphicsWidget based version of the "QWebView"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 07:07:26 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28862





--- Comment #36 from Simon Hausmann <hausmann at webkit.org>  2009-09-09 07:07:25 PDT ---
(In reply to comment #35)
> Returning to my idea posted as (In reply to comment #25)
> 
> > It sounds okay to me to introduce this class, but I would prefer to keep it
> > internal and not make it part of the public API initially. It seems more
> > sensible to me to utilize it as internal interface first to abstract away the
> > difference between QWebGraphicsItem and QWebView.
> 
> Actually, I'd like to make this _public_. Because right now there is a hassle
> in the moving from QWidget to QGraphicsThingy, and in the future the view
> object might change again and there are some use cases where the viewer is not
> a QWidget or QGraphicsThingy but wants the implicit updates from WebCore and
> the ability to optimize for scroll, etc. 
> 
> As for binary compatibility, it is NOT binary compatible, but if we take a
> little care it can atleast be source compatible with the old style QWebView
> usage. I am totally against having to support two different "view()'s ", rather
> replace the QWidget with the new dumby class that a user writes and we could
> also provide 3 public implementations of that class:
> 
> 1. where view() hooks into a QWebView
> 2. where view() hooks into a "QGraphicsView"
> 3. where view() hooks into a QPixmap, i.e. the derived object will have a
> pointer to a QPixmap to draw too.
> 
> This way, useful examples (in both showing how and actually useful by
> themselves) are exposed.

Unfortunately if it doesn't remain binary compatible it cannot be part of the
public API. That's exactly the issue, and that's also why Tor Arne suggested in
an earlier comment that we should use QWebPageClient as a staging area for API
that should become public once we're confident that it's a reasonable thing to
have in a view of QWebPage.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list