[Webkit-unassigned] [Bug 28964] [Chromium] ChromiumDataObject should have getter/setter interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 07:06:11 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28964


Roland Steiner <rolandsteiner at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39267|                            |review?
               Flag|                            |
  Attachment #39135|0                           |1
        is obsolete|                            |




--- Comment #5 from Roland Steiner <rolandsteiner at google.com>  2009-09-09 07:06:10 PDT ---
Created an attachment (id=39267)
 --> (https://bugs.webkit.org/attachment.cgi?id=39267)
patch: add getter/setter accessor methods


Removed 'inline' from methods.

> I take it that the "chromium code" in question lives outside of the WebKit
> tree?  So that we have to do this in two-stages like this?

Yes, the code in question is (Chromium) webkit\api\src\WebDragData.cpp .

The main reason for the change is that I want to implement
get/setData("text/uri-list") in Chromium.
(see https://bugs.webkit.org/show_bug.cgi?id=28293)
However, according to the HTML5 spec, "text/uri-list" and "URL" are not
independent.
So having WebDragData accessing a single 'url' member directly is inconvenient.

The getter/setter methods for the other members is just "collateral damage" ;)
(but it also allows cleaning up the naming).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list