[Webkit-unassigned] [Bug 28862] [Qt][API] Add a new QGraphicsWidget based version of the "QWebView"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28862





--- Comment #33 from Antonio Gomes (tonikitoo) <tonikitoo at gmail.com>  2009-09-09 04:14:28 PDT ---
> Overall, looks really good!
> r- until the issues above are addressed.

ariya, thanks for your comments.

(In reply to comment #22)
> (From update of attachment 39165 [details])
> 
> > +#include "qwebpage_p.h"
> Is this really needed?

so far, yes ... since we are doing this in dtror:

QWebGraphicsItem::~QWebGraphicsItem()
{
    if (d->page)
        d->page->d->view = 0;
(..)

> > +#include <QGraphicsScene>
> > +#include <QGraphicsView>
> Can we use the <QtGui/Foo> pattern also here?

done

> > +    setFlag(QGraphicsItem::ItemUsesExtendedStyleOption, true);
> This is Qt 4.6 only. Please guard it with QT_VERSION properly for <= 4.5.

done

> > +    if (this->progress == progress / 100.0)
> Please use qFuzzyCompare.

done


> > +bool QWebGraphicsItem::interactive() const
> Following Qt-ish naming, this should be isInteractive instead.
> > +    emit interactiveChanged();

done

> The name could be misleading. What about interactivityChanged?
> > +++ b/WebKit/qt/Api/qwebgraphicsitem_p.h
> Is there any reason we need separate file for this? Unline other qweb* classes, QWebGraphicsItemPrivate is not need by anyone else, right?

ok, i removed _p.h

> > +void QWebGraphicsItemPrivate::_q_doScroll(int dx, int dy, const QRect& rectToScroll)
> > +{
> > +    q->scroll(qreal(dx), qreal(dy), QRectF(rectToScroll));
> > +}
> 
> I found out that this does not really work if I subclass QWebGraphicsItem.
> An example: I have my customized QWebGraphicsItem that clips the painting so
> that the corners are rounded. When this function is invoked, say scrolling
> vertically, the whole painted item is scrolled, meaning the bottom rounded
> corners are also scrolled. The correct thing of course that the _contents_ of
> the web page is scrolled, not merely the item.
> The real fix would be to call update, instead of scroll. I understand that this is optimization issue, but I'd rather have a correctly painted item than a fast but garbage one.

as per discussed w/ kenneth and others,  I would rather let this issue to be
fixed in a followup bug if possible, as well as some other changes we are
listing here:

1) PageClient class (as well as make up a way to platformWidget to not return a
QWidget necessarily) - see comment #27
2) make cursor to work
3) Scroll optimization

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.