[Webkit-unassigned] [Bug 29068] NPAPI Plugin NPP_AsFile not working on Qt Webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29068


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39247|review?(hausmann at webkit.org |review-
               Flag|)                           |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2009-09-09 01:40:19 PDT ---
(From update of attachment 39247)
Your patch looks good in principle, thanks for tracking down this bug!

> +     QTemporaryFile *tempFile = new QTemporaryFile(QLatin1String(prefix));
> +     tempFile->setAutoRemove(false);
> +     QFile *temp = tempFile;

Please fix the coding style for the newly added lines, the position of the *
should be next to the type, not the variable.

Also please include a ChangeLog entry explaining your fix, using the same (very
good btw) explanation you
mentioned in this bugzilla entry.

r- because of that, but otherwise ok :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.