[Webkit-unassigned] [Bug 28327] Media layout tests should have a way to provide test files in different formats

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28327


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39249|review?                     |review+
               Flag|                            |




--- Comment #14 from Eric Carlson <eric.carlson at apple.com>  2009-09-08 23:55:01 PDT ---
(From update of attachment 39249)

> +function findMediaFile(type, name) {
> +function setSrcByTagName(tagName, src) {

  It would be clearer to use the same parameter names for the element type for
both functions, I think "tagName" is clearer than "type".


> +function setSrcById(id, src) {
> +    var elements = document.getElementById(id);
> +    if (elements)
> +        id.src = src;

  getElementById can only return a single element, so "elements" doesn't need
to be plural.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.