[Webkit-unassigned] [Bug 29065] New: svn-unapply doesn't revert directories correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29065

           Summary: svn-unapply doesn't revert directories correctly
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh Intel
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cam at mcc.id.au


Trying to unapply a patch that added a directory will not revert and then
remove that directory:


fox:~/svn/WebKit-2/WebKitTools $ cat /tmp/c.patch 
Index: NewDirectory/NewFile
===================================================================
--- NewDirectory/NewFile        (revision 0)
+++ NewDirectory/NewFile        (revision 0)
@@ -0,0 +1 @@
+
fox:~/svn/WebKit-2/WebKitTools $ ./Scripts/svn-apply /tmp/c.patch 
A         NewDirectory
patching file NewDirectory/NewFile
A         NewDirectory/NewFile
fox:~/svn/WebKit-2/WebKitTools $ ./Scripts/svn-unapply /tmp/c.patch 
patching file NewDirectory/NewFile
Reverted 'NewDirectory/NewFile'
A      NewDirectoryfox:~/svn/WebKit-2/WebKitTools $


Notice also that the svn status line printed by svn-unapply doesn't have a
newline.

Similarly, trying to unapply a patch that removed a directory will not revert
its deletion:


fox:~/svn/WebKit-2/WebKitTools $ svn rm record-memory-win
D         record-memory-win/record-memory-win.vcproj
D         record-memory-win/main.cpp
D         record-memory-win
fox:~/svn/WebKit-2/WebKitTools $ Scripts/svn-create-patch >/tmp/d.patch
fox:~/svn/WebKit-2/WebKitTools $ ./Scripts/svn-unapply /tmp/d.patch 
patching file record-memory-win/main.cpp
Reverted 'record-memory-win/main.cpp'
patching file record-memory-win/record-memory-win.vcproj
Reverted 'record-memory-win/record-memory-win.vcproj'
D      record-memory-winfox:~/svn/WebKit-2/WebKitTools $
fox:~/svn/WebKit-2/WebKitTools $ svn status record-memory-win 
D      record-memory-win

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.