[Webkit-unassigned] [Bug 28710] Copy some forms of text causes Webkit crash in CSSStyleDeclaration::copyPropertiesInSet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28710





--- Comment #20 from Justin Garcia <justin.garcia at apple.com>  2009-09-08 12:56:44 PDT ---
+    ContainerNode* elem = element();
+    // Allow document node to be passed if there

Comment is unnecessary since it just says what the code does.

> This patch somehow caused a whole bunch of tests to fail 
> because WebKit spits out a bunch of annoymous nodes and 
> empty text nodes.  Does anyone know why this happens?

Could you attach those diffs?

     // All text-decoration-related elements should have been treated as
special ancestors
     // If we ever hit this ASSERT, we should export StyleChange in
ApplyStyleCommand and use it here
-    ASSERT(propertyMissingOrEqualToNone(style, CSSPropertyTextDecoration) &&
propertyMissingOrEqualToNone(style, CSSPropertyWebkitTextDecorationsInEffect));
+    ASSERT(propertyMissingOrEqualToNone(style,
CSSPropertyWebkitTextDecorationsInEffect));

I think that the comment needs to be updated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.