[Webkit-unassigned] [Bug 28862] [Qt][API] Add a new QGraphicsWidget based version of the "QWebView"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 07:53:22 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28862


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vestbo at webkit.org




--- Comment #27 from Tor Arne Vestbø <vestbo at webkit.org>  2009-09-08 07:53:19 PDT ---
After a discussion with Simon we've come up with a strategy for the future
relationship/interface between QWebPage and QWebView et. al.

Basically we want the interface between the QWebPage and any clients to be as
clean and decoupled as possible, while still giving us freedom to do stuff like
the cursor changes. 

Right now the QWebPage interface is mostly in the form of a model in MVC terms,
where we have signals (and setters and getters) for changes in the page. We
have some hooks where we go directly to the QWebView, which of course increases
coupling.

What we propose is that we add a private client interface, QWebPageClient or
something, that QWebViewPrivate et al. will implement. The QWebPage will keep a
pointer to a client, and WebCore will pass on callbacks to the client for stuff
like the cursor change. (Side note: the cursor patch in bug 28865 should follow
this pattern in a future update, ie not use the dynamic property approach, but
that's OK for now).

As we see callbacks mature and stabilize in the private QWebPageClient we can
move them to the public QWebPage API by transforming into a proper decoupled
clean signal+getter/setter-interface, so any features/callbacks in the
QWebPageClient should have this in mind (ie. prepare for the future).

I think this will give us a good mix of a stable, well tested and decoupled
QWebPage API, while at the same time giving us the chance to do cool stuff for
QWebView and QWebGraphicsItem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list