[Webkit-unassigned] [Bug 28682] [Qt] QtWebKit Persistent API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28682


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39090|review?                     |review+
               Flag|                            |




--- Comment #7 from Simon Hausmann <hausmann at webkit.org>  2009-09-08 03:33:01 PDT ---
(From update of attachment 39090)
r=me

> +++ WebKit/qt/QtLauncher/main.cpp	(working copy)
> @@ -443,7 +443,7 @@ int main(int argc, char **argv)
>  
>      QWebSettings::globalSettings()->setAttribute(QWebSettings::PluginsEnabled, true);
>      QWebSettings::globalSettings()->setAttribute(QWebSettings::DeveloperExtrasEnabled, true);
> -    QWebSettings::globalSettings()->setAttribute(QWebSettings::LocalStorageEnabled, true);
> +    QWebSettings::globalSettings()->enablePersistentStorage();
>  

> @@ -152,6 +151,7 @@ DumpRenderTree::DumpRenderTree()
>      , m_notifier(0)
>  {
>      qt_drt_overwritePluginDirectories();
> +    QWebSettings::globalSettings()->enablePersistentStorage();
>  
>      m_controller = new LayoutTestController(this);
>      connect(m_controller, SIGNAL(done()), this, SLOT(dump()));

When landing, please change these to use
QWebSettings::enablePersistentStorage() instead of
QWebSettings::globalSettings()->enablePersistentStorage().

One could argue that DumpRenderTree should not share the persistent storage
files/path with the default browser location,
to avoid possible side-effects (towards either side :). But that's a minor
detail :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.