[Webkit-unassigned] [Bug 29024] Make JavaScriptCore compile on platforms with case-insensitive file systems and typeinfo.h in STL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 02:31:25 PDT 2009


--- Comment #3 from Kent Hansen <khansen at trolltech.com>  2009-09-08 02:31:25 PDT ---
(In reply to comment #2)
> (From update of attachment 39175 [details])
> When renaming a file like this you should update all references to the file so
> that you don't break the build.

Will fix.

> A few other points:
> 1) Includes should be kept in alphabetical order.

Will fix.

> 2) The JS prefix is typically reserved for objects that represent an object
> within the JavaScript environment (JSArray, JSString, etc).  Maybe this case is
> ok for the same reason that JSType is ok.
> 3) Classes live inside files of the same name.  Since you're renaming the file
> I suspect that you should rename the class to match.

Renaming the class itself would result in a much larger change.
Is there a better name we can use to avoid hi-jacking the JS prefix?
Renaming the file is the same solution as that already used for
WebCore/platform/text/PlatformString.h; see comment near top of file. I'll
update the patch to include a similar comment in JSTypeInfo.h.

> 4) You should explicit about which platform this is intended to fix.  It's
> quite clear that JavaScriptCore compiles on Mac OS X and Windows, both of which
> use case-insensitive file systems.  If roll out this change in the future and
> only test on those platforms, we'll break whatever platform it is you're trying
> to fix here.

I've updated the summary and will update the ChangeLog to be more explicit
about this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list