[Webkit-unassigned] [Bug 28907] [Qt] The --strict switch of run-webkit-tests does not work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 7 11:38:50 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28907


Andras Becsi <becsi.andras at stud.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|                            |FIXED
             Status|UNCONFIRMED                 |RESOLVED




--- Comment #12 from Andras Becsi <becsi.andras at stud.u-szeged.hu>  2009-09-07 11:38:50 PDT ---
Thank you very much for the extensive review, suggestions and help. 
I also noticed this possibility of simplification and I noticed a typo in the
Changelog text too (succesfull -> succesful), so I created a fixed patch:

http://gist.github.com/182506

-----------
(In reply to comment #11)
> I'll land this tomorrow.
> 
> Also, I just realized the stripMetrics() function can be simplified to:
> 
>     my ($actual, $expected) = @_;
> 
>     foreach my $result ($actual, $expected) {
>         $result =~ s/at \(-?[0-9]+,-?[0-9]+\) *//g;
>         ...
>     }
> 
> But I'll do that change before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list