[Webkit-unassigned] [Bug 28907] [Qt] The --strict switch of run-webkit-tests does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28907


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39149|review?(vestbo at webkit.org)  |review-
               Flag|                            |




--- Comment #8 from Tor Arne Vestbø <vestbo at webkit.org>  2009-09-07 08:42:22 PDT ---
(From update of attachment 39149)
Nice. A few finishing touches:

> +my $simpleTag = "simple";

This is no longer needed.

> +    'ignore-metrics' => \$ignoreMetrics,

Should be postixed with a ! since it's a boolean flag, this will make
GetOptions support --no-ignore-metrics, etc

>      'strip-editing-callbacks!' => \$stripEditingCallbacks,

Like this one

> +sub simplify($$)

Suggest renaming to stripMetrics()

> +    my $simpleExpected = $expected;
> +    my $simpleActual = $actual;

No need to assign these, you already have it in $actual and $expected.

> +    $simpleActual = $actual;

And def. no need to re-assign a second time ;)

> +    $simpleActual =~ s/at \(-?[0-9]+,-?[0-9]+\) *//g;

Just use $actual here, it's passed by value

> +    $simpleExpected =~ s/at \(-?[0-9]+,-?[0-9]+\) *//g;

Same, just use $expected directly

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.