[Webkit-unassigned] [Bug 28865] [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 7 08:11:52 PDT 2009


Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> changed:

           What    |Removed                     |Added
  Attachment #39126|review?                     |
               Flag|                            |

--- Comment #8 from Antonio Gomes (tonikitoo) <tonikitoo at gmail.com>  2009-09-07 08:11:51 PDT ---
(From update of attachment 39126)
clearing review(?) flag to address simon's feedback on IRC:

<tronical> tonikitoo, kenneth: I have an idea for teh cursor patch
<tronical> tonikitoo, kenneth: I _love_ your idea of using a dynamic property
instead of an event. that's indeed much more reusable for things like the
graphicsitem than the custom event
<tronical> tonikitoo, kenneth: but currently you do
setProperty("WebCoreCursor", cursor); and _then_ setCursor(cursor);
<tronical> tonikitoo, kenneth: instead it might be easier to distinguish
between the two cases, webcore setting teh cursor and QWidget::unsetCursor()
being called, by simply _not_ calling setCursor() from within WidgetQt.cpp
<tronical> tonikitoo, kenneth: and instead listening to
DynamicPropertyChangeEvent in QWebView

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list