[Webkit-unassigned] [Bug 28862] [Qt][API] Add a new QGraphicsWidget based version of the "QWebView"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 7 07:15:20 PDT 2009


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #39125|review?                     |review-
               Flag|                            |

--- Comment #15 from Simon Hausmann <hausmann at webkit.org>  2009-09-07 07:15:20 PDT ---
(From update of attachment 39125)
In principle this approach is good, QWebPage _should_ become capable of dealing
with QGraphicsScene events.

However this implementation duplicates a some of the existing event handlers
(drag'n'drop) and it converts
the graphicsview events to QWidget events and then calls the original handlers.
This means a lot of unnecessary
object creation.

I think it would be better to change the existing handlers, for example
QWebPagePrivate::mousePressEvent, to
take a PlatformMouseEvent as argument. Then PlatformMouseEvent should be
extended with a constructor that
accepts a QGraphicsSceneMouseEvent. This way the code in QWebPage::event()
takes care of just calling the
right constructors, the PlatformFooEvent constructors take care of extracting
the parameters and the logic
in QWebPagePrivate's event handlers can remain without the need of duplication.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list