[Webkit-unassigned] [Bug 29009] New: [V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 7 07:01:08 PDT 2009


           Summary: [V8] Cleanup document/frame null-checking in
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ager at chromium.org
                CC: dglazkov at chromium.org

The document and frame null checking in V8DOMWindowCustom.cpp is inconsistent
and a couple of checks are missing.

We should use the DOMWindow::document accessor and let that one null check the
frame.  We should always null check the result of that accessor. 
canAccessFrame returns false for a null frame - we should use that fact

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list