[Webkit-unassigned] [Bug 28907] [Qt] The --strict switch of run-webkit-tests does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28907


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39140|review?(ariya.hidayat at troll |review-, commit-queue-
               Flag|tech.com), commit-queue?    |




--- Comment #6 from Tor Arne Vestbø <vestbo at webkit.org>  2009-09-07 04:39:06 PDT ---
(From update of attachment 39140)
Good stuff, but can you please split up the --strict fix and the new option
into two separate patches?

A few comments:

>          print "\tThis allows the pixel tests to have consistent color values across all machines.\n";
> -        
> +
>          if (isPerianInstalled()) {

Don't add whitespace-hunks

> +    if ( !isAppleMacWebKit() && $strictTesting && !$isText ) {

No space in "if (something)"

> +        $excludeMetrics = 1;
> +        my $expectedFile = "$testDirectory/platform/mac/$expectedFileName";
> +        if ( !-s $expectedFile ) {
> +            $expectedFile = "$testDirectory/$expectedFileName";
> +        }

There can be several layers of results, see expectedDirectoryForTest() and
@platformResultHierarchy

> +        $modBase = catfile( $simplifiedDir, basename($base));

Space after (

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.