[Webkit-unassigned] [Bug 29006] New: WebInspector: Make m_windowVisible more consistent with the actual visibility of the inspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29006

           Summary: WebInspector: Make m_windowVisible more consistent
                    with the actual visibility of the inspector.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jocelyn.turcotte at nokia.com



Jocelyn Turcotte <jocelyn.turcotte at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39139|                            |review?(timothy at hatcher.nam
               Flag|                            |e)


Created an attachment (id=39139)
 --> (https://bugs.webkit.org/attachment.cgi?id=39139)
Suggested patch

We faced a bug that calling:
  page->inspectorController()->show()
  page->inspectorController()->inspect(...)
would not initialize the web inspector correctly.

The call to inspect() will also call InspectorController::show() which will
eventually call setWindowVisible() before the JS frontend has been initialized
and prevent the real call to do its initialization in setWindowVisible()
afterward.

This patch prevent the m_windowVisible flag to be modified if m_frontend has
not been initialized yet.

Adding a bool parameter showInspector to InspectorController::inspect() with a
default value of true would also correct this one problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.