[Webkit-unassigned] [Bug 28964] [Chromium] ChromiumDataObject should have getter/setter interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28964


Roland Steiner <rolandsteiner at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39135|                            |review?
               Flag|                            |
  Attachment #39047|0                           |1
        is obsolete|                            |




--- Comment #3 from Roland Steiner <rolandsteiner at google.com>  2009-09-07 01:26:00 PDT ---
Created an attachment (id=39135)
 --> (https://bugs.webkit.org/attachment.cgi?id=39135)
patch: add getter/setter accessor methods

Made the requested changes:

- content() method returns SharedBuffer*
- added new method PassRefPtr<SharedBuffer> releaseContent(), as it seems that
it'd be useful to have
- clarified the ChangeLog

Renaming the variables after they become private is already on the agenda. :)

On a further note: since I couldn't yet rename the member variables, and the
compiler complained if a getter method had the same name as a variable, I had
to be a bit creative when coming up with names. If you have other/better
suggestions, please let me know!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.