[Webkit-unassigned] [Bug 28918] Add support for Database.readTransaction()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28918





--- Comment #8 from Michael Nordman <michaeln at google.com>  2009-09-06 12:24:43 PDT ---
With this change we're changing the semantics of what 'readOnly' currently
means to the authorizer. 

The existing behavior is to support safari's private browsing mode and
generally (but no exactly) constrains any side effects of a statement to not be
visible outside of the connection to the database. Accordingly, creating and
deleting 'temp' objects only visible on that connection are allowable for
private browsing. The new readonly transaction semantics constrain any side
effects to not be visible outside of a transaction, which also excludes
creating and deleting 'temp' objects. There are also differences in how VIEWS
are treated, for private browsing purposes these can be created and deleted,
but in readonly transaction semantics these schema changes can't be made. 

Unless we can reconcile the two meanings of 'readOnly', we may need two
separate flags.


91 static JSValue DatabaseTransactionHelper(... RefPtr<Database> database, bool
readOnly)

I think Database* would be better.

104     executeStatement(tx, "DROP TABLE TestTempTable;",
"SQLITE_DROP_TEMP_TABLE");
105     executeStatement(tx, "DROP TRIGGER TestTempTrigger;",
"SQLITE_DROP_TEMP_TRIGGER");
106     executeStatement(tx, "DROP VIEW TestTempView;",
"SQLITE_DROP_TEMP_VIEW");

These lines look like they intend to operate on TEMP objects, but I don't think
they actually do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.