[Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27651


Jakub Wieczorek <faw217 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39120|                            |review?
               Flag|                            |
  Attachment #34896|0                           |1
        is obsolete|                            |
  Attachment #34896|review?                     |
               Flag|                            |




--- Comment #50 from Jakub Wieczorek <faw217 at gmail.com>  2009-09-06 01:51:11 PDT ---
Created an attachment (id=39120)
 --> (https://bugs.webkit.org/attachment.cgi?id=39120)
Add normalizePathForComparison() function to platform/FileSystem.

(In reply to comment #45)
> (In reply to comment #33)
> > (From update of attachment 33894 [details] [details])
> > This seems OK.  Maybe it should be called normalizePathForComparison if it's
> > only for comparison.  It's unclear what "normalize" should actually do?  Does
> > it resolve symlinks?  Does it remove traililing '/' chars?  Does it return the
> > ~1 windows form of paths?  r- for more explanation and or a better name...
> > 
> > In general I'm in favor of the concept though.  Another way would be to to just
> > have a arePathsEqual function. :)
> 
> I admit I prefer a function that does one thing, normalize a path by for
> example removing redundant pieces. arePathsEqual does two things, normalize and
> then compare. Unless the other operating systems have one function for both I
> can imagine that all the FileSystemXXX.cpp implementations are going to add an
> internal function to normalize and then do a string comparision :)

Alright, I got back to the old patch and renamed the function to
normalizePathForComparison(), according to Eric's suggestion.
For Qt it uses QDir::cleanPath(). If other ports could use something similar,
it should be sufficient.
http://doc.trolltech.com/4.5/qdir.html#cleanPath

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.