[Webkit-unassigned] [Bug 28954] hostname and host are mixed up when manipulating anchor elements

Sat Sep 5 21:12:35 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=28954

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39089|review?                     |review+
               Flag|                            |

--- Comment #10 from Darin Adler <darin at apple.com>  2009-09-05 21:12:35 PDT ---
(From update of attachment 39089)
> +    if (url.hostEnd() == url.pathStart())

I think it's slightly unclear to code it this way. I'd prefer to have a
hasPort() function on KURL. In fact, at one point these hostEnd() and
pathStart() functions didn't exist, and I'm not sure we'll want to keep them in
the long run.

But I guess this is OK as-is for now. I won't insist on changing KURL.h.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.