[Webkit-unassigned] [Bug 28991] Drop <definition-src> support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 5 01:39:22 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28991


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39103|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-09-05 01:39:22 PDT ---
(From update of attachment 39103)
I was so excited by this change, and then it looks like you snuck in a
functional change!
0     for (Node* child = firstChild(); child && !srcElement; child =
child->nextSibling()) {
 281         if (child->hasTagName(font_face_srcTag))

Before we would use the last source it seems, and now we use the first!  If
you're gonna do that, we need a test.

The rest of the change looked fine.  Glad to see this go!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list