[Webkit-unassigned] [Bug 28960] [Chromium] Need to add manifestUrl to ResourceResponse.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 22:08:26 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28960


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39027|review?                     |review-
               Flag|                            |




--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-09-04 22:08:26 PDT ---
(From update of attachment 39027)
> Index: WebCore/ChangeLog
...
> +2009-08-31  Michael Nordman  <michaeln at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Chromium appcache modifications.
> +
> +        No new tests.

nit: please include a link to this bug report.


> Index: WebCore/bindings/v8/custom/V8DOMApplicationCacheCustom.cpp
...
> +    if (EventListener* listener = appcache->getAttributeEventListener(toEventID(name)))
> +       return eventListenerToV8Object(listener);

nit: indentation should be 4 white spaces


> Index: WebCore/platform/network/chromium/ResourceResponse.h
...
> +        const KURL& getAppCacheManifestURL() const { return m_appCacheManifestURL; }

getters should not start with "get"... just call this appCacheManifestURL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list