[Webkit-unassigned] [Bug 28975] Can't upload images with "Hide Extension" set to imgur.com on chromium/mac
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 4 15:57:24 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=28975
David Levin <levin at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #39072|review? |review-
Flag| |
--- Comment #3 from David Levin <levin at chromium.org> 2009-09-04 15:57:24 PDT ---
(From update of attachment 39072)
Just some minor nits... Please fix and then I can go through this one more
time.
> Index: WebCore/platform/chromium/FileChooserChromium.cpp
> ===================================================================
> +#if PLATFORM(DARWIN)
> + // See crbug.com/20857.
> + string = pathGetPresentationalName(m_filenames[0]);
> +#else
> string = pathGetFileName(m_filenames[0]);
> +#endif
Add braces around this since there is more than one physical line here.
> Index: WebCore/platform/chromium/FileSystemChromiumMac.mm
> ===================================================================
> + // This has to return a real, existing filename with extension, see
> + // crbug.com/20857.
> + return [path lastPathComponent];
Use a 4 space indent throughout.
> +String pathGetPresentationalName(const String& path)
> +{
> + return [[NSFileManager defaultManager] displayNameAtPath:path];
Use a 4 space indent throughout.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list