[Webkit-unassigned] [Bug 28359] Cleanup: Undo some accidental changes around DOMApplicationCache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 13:58:42 PDT 2009


--- Comment #7 from Michael Nordman <michaeln at google.com>  2009-09-04 13:58:42 PDT ---

> layoutTestController.overridePreference("WebKitOfflineWebApplicationCacheEnabled",
> false);
> Does this really work on all platforms? You may need to add this new test to
> Skipped list for some (or maybe the platforms that don't have it already skip
> all tests http/tests/in appcache?)

I'm not able to run the tests on all other platforms.

layoutTestController seems to be very platform specific. For example, this
particular preference name was not being respected in chrome's test_shell for
example. I have a seperate CL to add support for this key in chrome land.

The others impls I looked at did seem to support this pref name in their
overridePreference method.

Worth pointing out that the test does not confirm if the pref is actually
disabled by the overridePreference call, nor does passage depend on the pref
actually being disabled. The test will PASS even if a feature is still enabled.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list