[Webkit-unassigned] [Bug 28964] [Chromium] ChromiumDataObject should have getter/setter interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28964


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39047|review?                     |review-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2009-09-04 11:52:43 PDT ---
(From update of attachment 39047)
r- for the PassRefPtr return value


> Index: WebCore/ChangeLog
> ===================================================================

> + Added interface methods.

Really you are adding methods to a class not to an interface. (You have
implementations here.)

> +
> +        No new tests.

Usually you would explain why there are no new tests.  For example,

  "No functional behavior change so no new tests."


> Index: WebCore/platform/chromium/ChromiumDataObject.h
> +        inline PassRefPtr<SharedBuffer> content() const { return fileContent; }

"If a function’s result is an object, but ownership is not being transferred,
the result should be a raw pointer. This includes most getter functions." --
http://webkit.org/coding/RefPtr.html

>          KURL url;
>          String urlTitle;

Later: Please consider renaming the variables to m_ when you make them private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.