[Webkit-unassigned] [Bug 28943] Logging fast* allocated heap usage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28943





--- Comment #4 from Balazs Kelemen <kb at inf.u-szeged.hu>  2009-09-04 09:03:04 PDT ---
(In reply to comment #3)
> The purpose of this code isn't particularly clear to me.  The comments say that
> it is only useful in debug builds, but debug builds of WebKit use the system
> memory allocator rather than TCMalloc.  This means that the usual memory
> profiling tools can easily be used to analyze memory usage.  That seems like a
> much more effective route to take.
> 

I think doing the profiling in the code directly (not with external tools)
has the advantage that we can better trust to the results. Btw, if you - the
core developers - does not agree with that, then this patch is not valid.

> I'd also recommend that you take a look at the WebKit coding style guidelines:
> <http://webkit.org/coding/coding-style.html>.  Of particular note are the lack
> of license headers on newly-added files, naming conventions, and brace
> placement.

This patch would be an initial version for starting konversation about the
stuff, so I did not deal with copyright or changelog.

> 
> The change to the fastMalloc function seems incorrect, as the early-return
> bypasses the "if (!result) CRASH;" when ENABLE(FAST_MALLOC_MATCH_VALIDATION) is
> true.

Rigth, it was a mistake.

> 
> It's not clear to me what this has to do with DBus or why there is
> DBus-specific code in this patch.

I used DBus to send a message to the MemLogger object what forces it to
generating a memory dump.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.