[Webkit-unassigned] [Bug 28938] CSS string value is not correctly serialized when it contains binary characters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 00:29:11 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28938


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38979|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-09-04 00:29:11 PDT ---
(From update of attachment 38979)
This would be much better as a js test/dom only test:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

YOu'd get shouldBeEqualToString for fre, instead of having to make your own
pass/fail functions.

This also doesn't need to be run from onload, you can run this from an inline
script tag (which making this a js test will do automatically).

No argument names needed here since tehy don't add clarity:
6 String quoteCSSString(const String& string);
 217 String quoteCSSStringIfNeeded(const String& string);
 218 String quoteCSSURLIfNeeded(const String& string);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list