[Webkit-unassigned] [Bug 28943] Logging fast* allocated heap usage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28943





--- Comment #3 from Mark Rowe (bdash) <mrowe at apple.com>  2009-09-03 19:23:28 PDT ---
The purpose of this code isn't particularly clear to me.  The comments say that
it is only useful in debug builds, but debug builds of WebKit use the system
memory allocator rather than TCMalloc.  This means that the usual memory
profiling tools can easily be used to analyze memory usage.  That seems like a
much more effective route to take.

I'd also recommend that you take a look at the WebKit coding style guidelines:
<http://webkit.org/coding/coding-style.html>.  Of particular note are the lack
of license headers on newly-added files, naming conventions, and brace
placement.

The change to the fastMalloc function seems incorrect, as the early-return
bypasses the "if (!result) CRASH;" when ENABLE(FAST_MALLOC_MATCH_VALIDATION) is
true.

It's not clear to me what this has to do with DBus or why there is
DBus-specific code in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.