[Webkit-unassigned] [Bug 28710] Copy some forms of text causes Webkit crash in CSSStyleDeclaration::copyPropertiesInSet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28710


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38845|0                           |1
        is obsolete|                            |




--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2009-09-03 17:01:30 PDT ---
Created an attachment (id=39020)
 --> (https://bugs.webkit.org/attachment.cgi?id=39020)
2nd attempt to fix the bug, requires rebaseline & DRT test

As I described above, we need to export StyleChange from ApplyStyleCommand and
use it in createMarkup.  But that means we might end up wrapping a bunch of
block elements with b, s, etc...  But this requires substential architectual
change of the editing code (takes at least several months).  So for time being,
we can ignore StyleWithCSS=false, and just fix the crash.

This patch tries to modify Position::computedStyle to allow document node to be
passed to computedStyle.  In addition, it modifies isElementPresentational not
to recognize html elements with text-decoration property.  Instead of treating
them as special ancestors, we'll preserve text decorations from the computed
style when we wrap the content with style span if necessary.

This patch somehow caused a whole bunch of tests to fail because WebKit spits
out a bunch of annoymous nodes and empty text nodes.  Does anyone know why this
happens?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.