[Webkit-unassigned] [Bug 28038] WebSocket API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28038


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38963|review?                     |review-
               Flag|                            |




--- Comment #24 from Alexey Proskuryakov <ap at webkit.org>  2009-09-03 13:51:33 PDT ---
(From update of attachment 38963)
> +        OwnPtr<char> m_buffer;
> +        int m_bufferSize;

The buffer is allocated with tryFastMalloc, but freed with delete, which will
cause problems on some configurations - in debug mode, it will be allocated
with malloc, but freed with delete. OwnPtr is not suitable for holding arrays
of data, I think that you may need to work with plain pointers here.

I should have noticed this earlier, sorry!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.