[Webkit-unassigned] [Bug 25503] Add instrumentation framework to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25503


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38838|review?(timothy at hatcher.nam |review-
               Flag|e)                          |




--- Comment #11 from Timothy Hatcher <timothy at hatcher.name>  2009-09-03 13:04:44 PDT ---
(From update of attachment 38838)
Looks good! Some small nits. Will r+ when you fix these.

> +    InspectorTimelineAgent* timelineAgent = inspectorTimelineAgent();
> +    if (timelineAgent)
> +        timelineAgent->willRecalculateStyle();

You can combine these into 2 lines. Same comment for the rest of the palces
like this.

    if (InspectorTimelineAgent* timelineAgent = inspectorTimelineAgent())
        timelineAgent->willRecalculateStyle();

> +    int i = 0;
> +    for (TimelineItems::const_iterator it(m_children.begin()); it != m_children.end(); ++it) {
> +        ScriptObject childObject = (*it)->convertToScriptObject(frontend);
> +        children.set(i++, childObject);
> +    }

Just use a normal for loop and a count and not iterators.

> +InspectorTimelineAgent* Page::inspectorTimelineAgent() const
> +{
> +    return m_inspectorController->timelineAgent();
> +}

You should inline this in the header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.