[Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 12:08:12 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27651


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34653|review?                     |review-
               Flag|                            |




--- Comment #42 from Simon Hausmann <hausmann at webkit.org>  2009-09-03 12:08:11 PDT ---
(From update of attachment 34653)
Jakub, the patch looks great to me, except for one _tiny_ buglet. I'll r+ it if
you
could leave the d pointers in there. Add the m_plugin, m_database, etc.
members, that's
great. But keep the (forward declared) d-pointers, too, even if they're unused.
_If_ 
something goes wrong we can still extend with the d-pointer and keep binary
compatibility.

Sorry :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list