[Webkit-unassigned] [Bug 28884] Add CreateRequestExtension to QWebPage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28884


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38880|review?(hausmann at webkit.org |review-
               Flag|)                           |




--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2009-09-03 12:01:10 PDT ---
(From update of attachment 38880)
I understand what you're trying to achieve (through earlier emails), but I
don't understand who this extension helps you to be able to track the
originating frame of a QNetworkRequest if nothing in WebCore/WebKit actually
call this function. The documentation also doesn't explain what I'm wondering
about:

    * What's the use of the output value?
    * Why does it have to be filled out?

Usually the extension pattern is used to allow developers to change existing
behaviour where we would normally add a new virtual function but cannot because
of binary compatibility constraints.

Perhaps all you need is a signal that is emitted whenever a request is created?
:)

Perhaps the request callbacks in FrameLoaderClientQt.cpp could be the source
that triggers the API?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.