[Webkit-unassigned] [Bug 28914] Add a test for iframe shims and windowed plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28914


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38996|review?                     |review-
               Flag|                            |




--- Comment #5 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-09-03 10:54:52 PDT ---
(From update of attachment 38996)
Quite a few of style issues below:

> Index: LayoutTests/ChangeLog
> ===================================================================
> --- LayoutTests/ChangeLog	(revision 47984)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,18 @@
> +2009-09-02  Victor Wang  <victorw at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=28914
> +
> +        Add layout test to test iframe shim can be used
> +        to overlay html above a windowed plugin. It checks
> +        premutations of iframe shimes in relationship to 

shimes => shims.

> +    var HEIGHT = 100;
width

> +    var WIDTH = 100;
height

> +        i.style.filter='progid:DXImageTransform.Microsoft.Alpha(style=0,opacity=0)';

This is IE-specific. Why do we need it here?

> +        var case_id = items;

caseId

> +        var expect_clickable = tags.expect && tags.expect.indexOf('UNDER') == -1;

expectClickable

> +        expected_clicks[case_id] = expect_clickable;

expectedClicks

> +        var plugin_div_z;

pluginDivZ

> +        var overlay_div_z_iframe;

overlayDivZIframe

> +        var overlay_div_z_overlay;

overlayDivZOverlay, and below, lots of underscore_delimited_var_names. WebKit
convention is camelCase.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.