[Webkit-unassigned] [Bug 27546] [GTK] context menu overriding API is very limited

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27546





--- Comment #6 from Christian Dywan <christian at twotoasts.de>  2009-09-03 10:51:54 PDT ---
Taking notes of what I notice when reading the patch:

- Can we list somewhere what  WEBKIT_WEB_TARGET_INFO_CONTEXT_MEDIA can be?

- WEBKIT_WEB_TARGET_INFO_CONTEXT_EDITABLE
We probably need to store the text in the target info?

- WEBKIT_WEB_TARGET_INFO_CONTEXT_SELECTION
We have no "public" way to obtain the selection.
webkit_web_view_get_selected_text is there but semi-private.

- You're not freeing all strings in webkit_web_target_info_finalize

- I wonder if "WebKitCopyLinkToClipboard" is necessary or redundant. Can this
conflict in practical use?

+    GtkAction* gtkAction =
ContextMenuItem::createNativeMenuItem(platformItem);
+    if (!gtkAction) {
+        g_warning("Item not added: %s", platformItem.title.utf8().data());
+        return;
+    }

I think this should say "Failed to create menu item for action: %s".

The example is nice. I should try to rewrite the menu in Midori and see how it
goes, also regarding hiding and adding actions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.