[Webkit-unassigned] [Bug 25930] Mismatched free

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25930


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38980|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2009-09-03 10:33:04 PDT ---
(From update of attachment 38980)
This may quiet valgrind, but it doesn't solve the problem.

There's still a mismatch. The allocation is fastNew of a CSSSelector and the
deallocation is fastDelete of a char. The fact that this currently works
doesn't mean it's matched up.

This also introduces a new mismatch, between the fastNew in
CSSParser::createFloatingSelector() and the delete done by the call to
deleteAllValues in ~CSSParser. If we change to fastNew we need to change the
delete to fastDelete.

The usage should be just fastDelete, not WTF::fastDelete.

---

We could add a variant of fastDelete that does not call a destructor, and fix
the mismatch that way. There may be some other good solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.