[Webkit-unassigned] [Bug 27787] The type information about the resource loading is not forwarded to the network layer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 01:12:31 PDT 2009


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #34879|review?                     |review-
               Flag|                            |

--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-09-03 01:12:31 PDT ---
(From update of attachment 34879)
In general this looks good!

Please remove this:
42     default:
 243          return Other;
and put a "return Other" after the switch.  See my previous comment about
default: cases for switches over enums as being bad. :)

We could avoid all this search/replace by adding a typedef
ResourceRequestBase::Type Type; into CachedResponse.  I'm not sure I really
care one way or the other, but it would definitely make the patch smaller.

 45     case ResourceRequestBase::ImageResource :
(no space after value before ':')

Otherwise looks good.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list