[Webkit-unassigned] [Bug 27371] [WINCE] Add WinCE specific platform/text files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27371


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38902|review?                     |review-
               Flag|                            |




--- Comment #15 from Eric Seidel <eric at webkit.org>  2009-09-03 01:03:28 PDT ---
(From update of attachment 38902)
Style:
 247     static WordBreakIterator *iterator = 0;

Also, these lines can be combined:
247     static WordBreakIterator *iterator = 0;
 248     if (!iterator)
 249         iterator = new WordBreakIterator;

static WordBreakIterator* iterator = new WordBreakIterator;

that will only run once on the function's first run.  Likewise you could just
use:

static WordBreakIterator iterator; and return &iterator instead.  Although you
might need to use the DEFINE_STATIC_LOCAL macro.

Please add a contructor for your BreakIterators sine they all seem to share the
same initialization code.

Longer variable names are preferrd:
int textBreakFirst(TextBreakIterator* bi)
 298 {
 299     return bi->first();
 300 }

Why WebCore::?
 420         WebCore::decode(result, m_encoding.name(), bytes, length, &left,
m_decodeBuffer.isEmpty(), sawInvalidChar);

Why L'' here?
 427         result.append(L'?');

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.