[Webkit-unassigned] [Bug 26584] [Qt] Printing extra information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26584


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34390|review?                     |review-
               Flag|                            |




--- Comment #15 from Eric Seidel <eric at webkit.org>  2009-09-03 00:56:24 PDT ---
(From update of attachment 34390)
You ChangeLog entry is malformed.

style:
 1152 quint32 QWebFrame::countPages(QPrinter* printer) const {

c++ code in WebCore uses static_cast<int>:
+                     int(qprinterRect.width() / zoomFactorX),
+                     int(qprinterRect.height() / zoomFactorY));

WebCore style is to omit argument names when they don't add value:
 #ifndef QT_NO_PRINTER
-    void print(QPrinter *printer) const;
+    void print(QPrinter* printer) const;
+    void print(QPrinter* printer, QPainter* painter) const;
 #endif
maye that's not true of qt?

Since no Qt person has made a comment on this in the 20+ days that it has been
up or review, I can only assume they don't want this patch.  I would encourage
you to try and track down a Qt reviewer (ideally over email) and get their
attention before posting the revised version.

r- for the nits above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.