[Webkit-unassigned] [Bug 28781] Add QWebFrame::renderElement to API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28781


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38748|review?                     |review-
               Flag|                            |




--- Comment #3 from Tor Arne Vestbø <vestbo at webkit.org>  2009-09-02 05:14:30 PDT ---
(From update of attachment 38748)
> +void QWebElement::render(QPainter *painter)

Need docs

> +    Frame* fr = doc->frame();

Style, use meaningful variable names.

> +    if ( !fr || !fr->view() || !fr->contentRenderer())
> +        return;
> +
> +    IntRect p_rect = e->getRect();

Same as above + camelCase, not _

Goes for all of the variables in the method.

> +    void render(QPainter *painter);

Need autotest

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.