[Webkit-unassigned] [Bug 28272] WINCE PORT: graphics files only for WINCE

Tue Sep 1 18:49:21 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=28272

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34769|review?                     |review-
               Flag|                            |

--- Comment #4 from Adam Barth <abarth at webkit.org>  2009-09-01 18:49:21 PDT ---
(From update of attachment 34769)
+ static inline int stableRound

Why is this function WINCE specific?

+ PassRefPtr<WebCore::SharedBuffer> loadResourceIntoBuffer(const char* name);

Why are we declaring a function in a cpp file?

Also, these things should be happening in the WebCore namespace.

Aside from these minor issues, this patch actually looks somewhat reasonable. 
I'm not a graphics expert, however.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.