[Webkit-unassigned] [Bug 28150] WINCE PORT: Image Encoders

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28150





--- Comment #3 from Yong Li <yong.li at torchmobile.com>  2009-09-01 18:38:17 PDT ---
(In reply to comment #2)
> (From update of attachment 34480 [details])
> 
> + dest->next_output_byte  = reinterpret_cast<JOCTET*>(dest->m_buffer.data());
> 
> This line and the following line are not proper WebKit style.  Note: this style
> error is made repeatedly throughout the file.

many of the variable names and struct names are from libjpeg.

> Magic constants following this line should be removed.
> 
> + // This section of the code is based on nsPNGEncoder.cpp in Mozilla
> 
> I suspect we're missing the Mozilla license block then.
> 
> Also, your ChangeLog leads me to believe this patch contains a bunch of
> copy-and-paste code duplication.

yes PNGEncoder is mostly copied from image-encoders\skia. In the later image
code refractoring, the code should be extracted out for share.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.