[Webkit-unassigned] [Bug 28264] Add Mock Geolocation service for use in LayoutTests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28264


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35155|review?                     |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2009-09-01 16:00:56 PDT ---
(From update of attachment 35155)
+    static FactoryFunction* s_factoryFunction;

Usually we just declare these statically in the cpp file instead of declaring
them in the h file.

+++ WebCore/platform/MockGeolocationService.cpp    (revision 0)

Does WebCore have other Mock classes?  This should probably live in
WebKitTools/DumpRenderTree

What's the benefit of holding all that data in the Mock class as statics versus
just holding them as members of the instance?

+ GeolocationService::FactoryFunction* GeolocationService::s_factoryFunction =
&GeolocationServiceMac::create;

I don't think this a very common pattern in WebCore...  I there must be a
better way to create this Mock service.

+ #import <WebKit/WebMockGeolocation.h>

This probably need to be a private API header.  Otherwise, the header will need
to go through MacOS API review.

I'm not really sure what the best approach is here.  We should consult with
some WebCore/platform experts on the best way to test against mock platform
features.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.