[Webkit-unassigned] [Bug 28877] New: Implement bugzilla-tool mark-fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 09:42:11 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28877

           Summary: Implement bugzilla-tool mark-fixed
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: aroben at apple.com



David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38867|                            |review?
               Flag|                            |


Created an attachment (id=38867)
 --> (https://bugs.webkit.org/attachment.cgi?id=38867)
Patch v1

Reviewed by NOBODY (OOPS!).

The mark-fixed subcommand is for those times when you don't use
bugzilla-tool to commit a patch, but you want to use it to close
the bug with a committed-revision message.

* Scripts/bugzilla-tool:
(bug_comment_from_svn_revision): Added.  Extracted from
bug_comment_from_commit_text().
(bug_comment_from_commit_text): Extracted
bug_comment_from_svn_revision() from this method.
(MarkBugFixed.__init__): Added.
(MarkBugFixed._determine_bug_id_and_svn_revision): Added.
Attempts to use bug id and svn revision passed in from the
command-line, but falls back to checking the last svn commit log
if either isn't defined.
(MarkBugFixed.execute): Added.  Adds a comment about the
revision that fixed the bug and closes the bug.
(BugzillaTool.__init__): Added mark-fixed subcommand.
* Scripts/modules/bugzilla.py:
(Bugzilla.fetch_title_from_bug): Added.
* Scripts/modules/scm.py:
(SCM.last_svn_commit_log): Added.  Subclasses must override.
(SVN.last_svn_commit_log): Added.  Uses svnversion to find the
last commit in an svn working directory and then runs svn log.
(Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
of one log message.
---
 4 files changed, 115 insertions(+), 2 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list