[Webkit-unassigned] [Bug 28868] [HTML5][Forms] :valid/:invalid/:optional/:required CSS selectors should be applied lively

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 07:47:47 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28868





--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-09-01 07:47:47 PDT ---
(From update of attachment 38854)
I probably would have used a function to make the test output more readable:
+PASS document.defaultView.getComputedStyle(el,
null).getPropertyValue("background-color") is "rgb(255, 0, 0)"

function backgroundOf(el)
{
    return document.defaultView.getComputedStyle(el,
null).getPropertyValue("background-color");
}

PASS backgroundOf(el) is "rgb(255, 0, 0)"

or maybe even:

PASS backgroundOf(el) is "red"

Slightly sad to see custom edited html files instead of just using .js files
and the standard TEMPLATE.html, but these are fine. :)

Those comments above are just nits, not requiring any change.  I'd need to
stare at the c++ part of this more to make a real review decision...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list