[Webkit-unassigned] [Bug 30983] Remove obsolete assertions from CanvasRenderingContext3DMac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 31 15:54:38 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30983


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42261|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2009-10-31 15:54:38 PDT ---
(From update of attachment 42261)
> +    ASSERT(program && shader);

We should always use multiple assertions instead of an && in an assertion,
because that way we can tell which one fails.

The title of this bug does not match the patch. The patch does not remove
assertions. It adds assertions and removes unneeded runtime checks.

review- because although the problems with the patch are extremely minor, the
benefit of the patch is also minor

Please fix the title and don't use && in assertions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list