[Webkit-unassigned] [Bug 30980] New: Cleanup in wx code: avoid unnecessary wxString::mb_str() calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30980

           Summary: Cleanup in wx code: avoid unnecessary
                    wxString::mb_str() calls
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P4
         Component: WebKit wx
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: vz-webkit at zeitlins.org



Vadim Zeitlin <vz-webkit at zeitlins.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42258|                            |review?, commit-queue?
               Flag|                            |


Created an attachment (id=42258)
 --> (https://bugs.webkit.org/attachment.cgi?id=42258)
Patch removing unnecessary wxString::mb_str() calls

While debugging the bug 30977 I noticed that in a few places in the code there
were ugly-looking explicit conversions between wxString and WebCore::String.
They seem to be unnecessary as there is already an implicit ctor in String from
wxString so IMO we should be simply using it because just "baseUrl" looks much
better than "static_cast<const char*>(baseUrl.mb_str(wxConvUTF8))". So I attach
a patch which simply removes these calls.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.