[Webkit-unassigned] [Bug 29972] Implement URL decomposition IDL attributes for HTMLAnchorElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 17:31:33 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29972





--- Comment #14 from Darin Adler <darin at apple.com>  2009-10-30 17:31:32 PDT ---
(In reply to comment #11)
> One test case (line 23) in fast/loader/url-parse-1.html is failing with my
> patch. It expects that we always add '/' if the path is empty, but we should
> only add that if the URL is hierarchical. (IE8 does not add that)
> Should I change the expected result in the same patch, or as a follow-up?

You must change the expected result in the same patch where you change
behavior. All tests have to pass.

Another option is to do that particular bug fix separately in a previous patch.
That would be better than including the fix with the rest of your work here.
One task per patch is best.

A third option is to leave the code change for that bug fix out, and land your
initial work leaving that broken. Your expected test results need to reflect
the expected failure. Then you could do a follow-up that both adds the code
change and changes the expected results to reflect the new successes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list