[Webkit-unassigned] [Bug 30505] Counters aren't updated when a new counter-increment is added

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30505





--- Comment #6 from Darin Adler <darin at apple.com>  2009-10-30 14:52:33 PDT ---
(From update of attachment 42237)
> +void RenderCounter::addCounterNodes(RenderObject* object) {

Brace needs to be on the following line, not the same line.

I don’t understand the high level concept of this patch enough to review it. I
believe the idea here is that it's important to explicitly create some counter
nodes in certain cases. So you added a function that calls the counter function
in RenderCounter.cpp because of its side effect. But I don't understand why
creating more counter nodes is the way to fix a bug.

What is the nature of the bug?

Further, what does isRooted have to do with any of this? It seems clearly wrong
to be walking up the entire render tree looking for a RenderView in this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.